first commit
This commit is contained in:
29
customerportal/include/htmlpurify/docs/dev-code-quality.txt
Normal file
29
customerportal/include/htmlpurify/docs/dev-code-quality.txt
Normal file
@@ -0,0 +1,29 @@
|
||||
|
||||
|
||||
Code Quality Issues
|
||||
|
||||
|
||||
|
||||
Okay, face it. Programmers can get lazy, cut corners, or make mistakes. They
|
||||
|
||||
also can do quick prototypes, and then forget to rewrite them later. Well,
|
||||
|
||||
while I can't list mistakes in here, I can list prototype-like segments
|
||||
|
||||
of code that should be aggressively refactored. This does not list
|
||||
|
||||
optimization issues, that needs to be done after intense profiling.
|
||||
|
||||
|
||||
|
||||
docs/examples/demo.php - ad hoc HTML/PHP soup to the extreme
|
||||
|
||||
|
||||
|
||||
AttrDef - a lot of duplication, more generic classes need to be created;
|
||||
|
||||
a lot of strtolower() calls, no legit casing
|
||||
|
||||
Class - doesn't support Unicode characters (fringe); uses regular expressions
|
||||
|
||||
Lang - code duplication; premature optimization
|
||||
Reference in New Issue
Block a user